espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-10-06 07:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

[netdata] use Mle constants in RemoveTemporaryData() methods (#11813)

Browse Source 
This commit replaces hardcoded magic numbers for RLOC addresses with
their corresponding named constants from the `Mle` namespace.

- The DHCP Agent RLOC is now set using `Mle::kAloc16DhcpAgentStart`.
- The invalid RLOC address `0xfffe` is replaced by `Mle::kInvalidRloc16`.

This change improves code readability and maintainability. Redundant
comments were also removed.
This commit is contained in:
Abtin Keshavarzian
2025-08-13 10:17:55 -07:00
committed by GitHub
parent b89d05c5fc
commit ed95672bc0
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/thread/network_data.cpp
+5 -9
View File
@@ -581,17 +581,16 @@ bool MutableNetworkData::RemoveTemporaryDataIn(PrefixTlv &aPrefix)
BorderRouterTlv *borderRouter = As<BorderRouterTlv>(cur);
ContextTlv *context = aPrefix.FindSubTlv<ContextTlv>();
// Replace p_border_router_16
for (BorderRouterEntry *entry = borderRouter->GetFirstEntry(); entry <= borderRouter->GetLastEntry();
entry = entry->GetNext())
{
if ((entry->IsDhcp() || entry->IsConfigure()) && (context != nullptr))
{
entry->SetRloc(0xfc00 | context->GetContextId());
entry->SetRloc(Mle::kAloc16DhcpAgentStart + context->GetContextId() - 1);
}
else
{
entry->SetRloc(0xfffe);
entry->SetRloc(Mle::kInvalidRloc16);
}
}
@@ -602,11 +601,10 @@ bool MutableNetworkData::RemoveTemporaryDataIn(PrefixTlv &aPrefix)
{
HasRouteTlv *hasRoute = As<HasRouteTlv>(cur);
// Replace r_border_router_16
for (HasRouteEntry *entry = hasRoute->GetFirstEntry(); entry <= hasRoute->GetLastEntry();
entry = entry->GetNext())
{
entry->SetRloc(0xfffe);
entry->SetRloc(Mle::kInvalidRloc16);
}
break;
@@ -616,13 +614,12 @@ bool MutableNetworkData::RemoveTemporaryDataIn(PrefixTlv &aPrefix)
break;
}
// keep stable tlv
cur = cur->GetNext();
}
else
{
// remove temporary tlv
uint8_t subTlvSize = cur->GetSize();
RemoveTlv(cur);
aPrefix.SetSubTlvsLength(aPrefix.GetSubTlvsLength() - subTlvSize);
}
@@ -649,13 +646,12 @@ bool MutableNetworkData::RemoveTemporaryDataIn(ServiceTlv &aService)
break;
}
// keep stable tlv
cur = cur->GetNext();
}
else
{
// remove temporary tlv
uint8_t subTlvSize = cur->GetSize();
RemoveTlv(cur);
aService.SetSubTlvsLength(aService.GetSubTlvsLength() - subTlvSize);
}