espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-03 01:17:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

MleRouter: Use mAttachChallenge when sending "Child Update Request" (#1402)

Browse Source 
- In `SendChildUpdateRequest()` use the child's `mAttachChallenge`
  feild to store the challenge instead of `mPending.mChallenge`.

- This ensures that the child's `mValid.mRloc16` is not overwritten
  after sending "child update response".
This commit is contained in:
Abtin Keshavarzian
2017-03-01 08:23:19 -08:00
committed by Jonathan Hui
parent 590d8f055a
commit ee6b0c9b8f
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/thread/mle_router.cpp
+5 -5
View File
@@ -2303,7 +2303,7 @@ ThreadError MleRouter::HandleChildUpdateResponse(const Message &aMessage, const
if (Tlv::GetTlv(aMessage, Tlv::kResponse, sizeof(response), response) == kThreadError_None)
{
VerifyOrExit(response.IsValid() &&
memcmp(response.GetResponse(), child->mPending.mChallenge, sizeof(child->mPending.mChallenge)) == 0, ;);
memcmp(response.GetResponse(), child->mAttachChallenge, sizeof(child->mAttachChallenge)) == 0, ;);
}
// Link-Layer Frame Counter
@@ -2716,13 +2716,13 @@ ThreadError MleRouter::SendChildUpdateRequest(Child *aChild)
SuccessOrExit(error = AppendPendingTimestamp(*message));
SuccessOrExit(error = AppendTlvRequest(*message, tlvs, sizeof(tlvs)));
for (uint8_t i = 0; i < sizeof(aChild->mPending.mChallenge); i++)
for (uint8_t i = 0; i < sizeof(aChild->mAttachChallenge); i++)
{
aChild->mPending.mChallenge[i] = static_cast<uint8_t>(otPlatRandomGet());
aChild->mAttachChallenge[i] = static_cast<uint8_t>(otPlatRandomGet());
}
SuccessOrExit(error = AppendChallenge(*message, aChild->mPending.mChallenge,
sizeof(aChild->mPending.mChallenge)));
SuccessOrExit(error = AppendChallenge(*message, aChild->mAttachChallenge,
sizeof(aChild->mAttachChallenge)));
memset(&destination, 0, sizeof(destination));
destination.mFields.m16[0] = HostSwap16(0xfe80);