espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-04 09:57:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[nat64] rename NAT64 discovery handlers for clarity (#12034)

Browse Source 
This commit renames NAT64 prefix discovery handler functions in
`RoutingManager` and `Nat64PrefixManager` to be more specific. This is
a non-functional refactoring that improves code clarity and
maintainability.

The new names, `HandleInfraIfDiscoverNat64PrefixDone` and
`HandleInfraIfDiscoverDone`, clarify that these handlers are for NAT64
prefixes discovered on the infrastructure interface.

This change makes the code easier to understand and prepares it for
potential future enhancements, such as discovering NAT64 prefixes from
Router Advertisements.
This commit is contained in:
Yang Song
2025-10-14 16:35:31 +02:00
committed by GitHub
parent 46f728b64c
commit f19864a2ac
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/border_router/infra_if.cpp
+1 -1
View File
@@ -122,7 +122,7 @@ void InfraIf::DiscoverNat64PrefixDone(uint32_t aIfIndex, const Ip6::Prefix &aPre
VerifyOrExit(mInitialized && mIsRunning, error = kErrorInvalidState);
VerifyOrExit(aIfIndex == mIfIndex, error = kErrorInvalidArgs);
Get<RoutingManager>().HandleDiscoverNat64PrefixDone(aPrefix);
Get<RoutingManager>().HandleInfraIfDiscoverNat64PrefixDone(aPrefix);
exit:
if (error != kErrorNone)
src/core/border_router/routing_manager.cpp
+3 -2
View File
@@ -2614,11 +2614,12 @@ void RoutingManager::Nat64PrefixManager::Discover(void)
}
}
void RoutingManager::Nat64PrefixManager::HandleDiscoverDone(const Ip6::Prefix &aPrefix)
void RoutingManager::Nat64PrefixManager::HandleInfraIfDiscoverDone(const Ip6::Prefix &aPrefix)
{
mInfraIfPrefix = aPrefix;
LogInfo("Infraif NAT64 prefix: %s", mInfraIfPrefix.IsValidNat64() ? mInfraIfPrefix.ToString().AsCString() : "none");
LogInfo("InfraIf Discovered NAT64 prefix: %s",
mInfraIfPrefix.IsValidNat64() ? mInfraIfPrefix.ToString().AsCString() : "none");
Get<RoutingManager>().ScheduleRoutingPolicyEvaluation(kAfterRandomDelay);
}
src/core/border_router/routing_manager.hpp
+5 -2
View File
@@ -437,7 +437,10 @@ public:
*
* @param[in] aPrefix The discovered NAT64 prefix on `InfraIf`.
*/
void HandleDiscoverNat64PrefixDone(const Ip6::Prefix &aPrefix) { mNat64PrefixManager.HandleDiscoverDone(aPrefix); }
void HandleInfraIfDiscoverNat64PrefixDone(const Ip6::Prefix &aPrefix)
{
mNat64PrefixManager.HandleInfraIfDiscoverDone(aPrefix);
}
#endif // OPENTHREAD_CONFIG_NAT64_BORDER_ROUTING_ENABLE
@@ -914,7 +917,7 @@ private:
const Ip6::Prefix &GetLocalPrefix(void) const { return mLocalPrefix; }
const Ip6::Prefix &GetFavoredPrefix(RoutePreference &aPreference) const;
void Evaluate(void);
void HandleDiscoverDone(const Ip6::Prefix &aPrefix);
void HandleInfraIfDiscoverDone(const Ip6::Prefix &aPrefix);
void HandleTimer(void);
private: