[style] remove using decls from global namespace in headers (#3705)

src/core/coap/coap_message.hpp

@@ -45,8 +45,6 @@
 #include "common/message.hpp"
 #include "utils/static_assert.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-
 namespace ot {
 
 /**
@@ -57,6 +55,8 @@ namespace ot {
  */
 namespace Coap {
 
+using ot::Encoding::BigEndian::HostSwap16;
+
 /**
  * @addtogroup core-coap
  *

src/core/common/tlvs.hpp

@@ -41,11 +41,11 @@
 #include "common/encoding.hpp"
 #include "common/message.hpp"
 
+namespace ot {
+
 using ot::Encoding::BigEndian::HostSwap16;
 using ot::Encoding::BigEndian::HostSwap32;
 
-namespace ot {
-
 /**
  * This class implements TLV generation and parsing.
  *

src/core/meshcop/meshcop_tlvs.hpp

@@ -51,13 +51,13 @@
 #include "net/ip6_address.hpp"
 #include "phy/phy.hpp"
 
+namespace ot {
+namespace MeshCoP {
+
 using ot::Encoding::Reverse32;
 using ot::Encoding::BigEndian::HostSwap16;
 using ot::Encoding::BigEndian::HostSwap32;
 
-namespace ot {
-namespace MeshCoP {
-
 /**
  * This class implements MeshCoP TLV generation and parsing.
  *

src/core/meshcop/timestamp.hpp

@@ -43,11 +43,11 @@
 
 #include "common/encoding.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-
 namespace ot {
 namespace MeshCoP {
 
+using ot::Encoding::BigEndian::HostSwap16;
+
 /**
  * This class implements Timestamp generation and parsing.
  *

src/core/net/dhcp6.hpp

@@ -39,12 +39,12 @@
 #include "common/message.hpp"
 #include "net/udp6.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 namespace Dhcp6 {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * @addtogroup core-dhcp6
  *

src/core/net/dns_headers.hpp

@@ -41,9 +41,6 @@
 #include "common/encoding.hpp"
 #include "common/message.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 
 /**
@@ -54,6 +51,9 @@ namespace ot {
  */
 namespace Dns {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * @addtogroup core-dns
  *

src/core/net/icmp6.hpp

@@ -42,11 +42,11 @@
 #include "common/locator.hpp"
 #include "net/ip6_headers.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-
 namespace ot {
 namespace Ip6 {
 
+using ot::Encoding::BigEndian::HostSwap16;
+
 /**
  * @addtogroup core-ip6-icmp6
  *

src/core/net/ip6.hpp

@@ -53,9 +53,6 @@
 #include "net/socket.hpp"
 #include "net/udp6.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 
 /**
@@ -67,6 +64,9 @@ namespace ot {
  */
 namespace Ip6 {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * @addtogroup core-ipv6
  *

src/core/net/ip6_headers.hpp

@@ -44,9 +44,6 @@
 #include "net/netif.hpp"
 #include "net/socket.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 
 /**
@@ -58,6 +55,9 @@ namespace ot {
  */
 namespace Ip6 {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * @addtogroup core-ipv6
  *

src/core/net/sntp_client.hpp

@@ -46,6 +46,8 @@
 namespace ot {
 namespace Sntp {
 
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * This class implements SNTP header generation and parsing.
  *

src/core/thread/lowpan.hpp

@@ -63,6 +63,8 @@ namespace ot {
  */
 namespace Lowpan {
 
+using ot::Encoding::BigEndian::HostSwap16;
+
 /**
  * This structure represents a LOWPAN_IPHC Context.
  *

src/core/thread/mle_tlvs.hpp

@@ -45,13 +45,13 @@
 #include "net/ip6_address.hpp"
 #include "thread/mle_constants.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 
 namespace Mle {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 #define TLVREQUESTTLV_ITERATOR_INIT 0 ///< Initializer for TlvRequestTlvIterator.
 
 typedef uint8_t TlvRequestIterator; ///< Used to iterate through TlvRequestTlv.

src/core/thread/network_data_tlvs.hpp

@@ -41,13 +41,13 @@
 #include "common/encoding.hpp"
 #include "net/ip6_address.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-
 #define THREAD_ENTERPRISE_NUMBER 44970
 
 namespace ot {
 namespace NetworkData {
 
+using ot::Encoding::BigEndian::HostSwap16;
+
 /**
  * @addtogroup core-netdata-tlvs
  *

src/core/thread/network_diagnostic_tlvs.hpp

@@ -48,13 +48,13 @@
 #include "phy/phy.hpp"
 #include "thread/mle_constants.hpp"
 
-using ot::Encoding::BigEndian::HostSwap16;
-using ot::Encoding::BigEndian::HostSwap32;
-
 namespace ot {
 
 namespace NetworkDiagnostic {
 
+using ot::Encoding::BigEndian::HostSwap16;
+using ot::Encoding::BigEndian::HostSwap32;
+
 /**
  * @addtogroup core-mle-tlvs
  *

src/core/thread/thread_tlvs.hpp

@@ -42,11 +42,11 @@
 #include "net/ip6_address.hpp"
 #include "thread/mle.hpp"
 
+namespace ot {
+
 using ot::Encoding::BigEndian::HostSwap16;
 using ot::Encoding::BigEndian::HostSwap32;
 
-namespace ot {
-
 enum
 {
     kCoapUdpPort = 61631,