espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-11-13 18:01:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] set SO_NOSIGPIPE to 1 on daemon session sockets (#13639)

Browse Source 
`InitializeSessionSocket()` passes `&rval` as the option value right
after `rval = fcntl(F_SETFD, ...)` returned 0, so `SO_NOSIGPIPE` is set
to 0 and stays disabled. A `write()` to a session whose client has gone
then raises `SIGPIPE`, and the daemon, which installs no handler, exits
silently. Linux is unaffected because it uses `MSG_NOSIGNAL`.
This commit is contained in:
Clara
2026-09-28 11:36:42 -07:00
committed by GitHub
parent 60dccaaf10
commit f98737de1e
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/daemon.cpp
+9 -5
View File
@@ -105,7 +105,7 @@ int Daemon::OutputFormatV(const char *aFormat, va_list aArguments)
VerifyOrExit(mSessionSocket != -1);
#ifdef __linux__
#ifdef MSG_NOSIGNAL
// Don't die on SIGPIPE
rval = send(mSessionSocket, buf, static_cast<size_t>(rval), MSG_NOSIGNAL);
#else
@@ -136,18 +136,22 @@ void Daemon::InitializeSessionSocket(void)
VerifyOrExit((rval = fcntl(newSessionSocket, F_SETFD, rval)) != -1);
#ifndef __linux__
#ifndef MSG_NOSIGNAL
// some platforms (macOS, Solaris) don't have MSG_NOSIGNAL
// SOME of those (macOS, but NOT Solaris) support SO_NOSIGPIPE
// if we have SO_NOSIGPIPE, then set it. Otherwise, we're going
// to simply ignore it.
#if defined(SO_NOSIGPIPE)
rval = setsockopt(newSessionSocket, SOL_SOCKET, SO_NOSIGPIPE, &rval, sizeof(rval));
VerifyOrExit(rval != -1);
{
const int on = 1;
rval = setsockopt(newSessionSocket, SOL_SOCKET, SO_NOSIGPIPE, &on, sizeof(on));
VerifyOrExit(rval != -1);
}
#else
#warning "no support for MSG_NOSIGNAL or SO_NOSIGPIPE"
#endif
#endif // __linux__
#endif // MSG_NOSIGNAL
if (mSessionSocket != -1)
{