List skipped PR Review files (#648)
Signed-off-by: Glenn Jocher <[email protected]> Co-authored-by: UltralyticsAssistant <[email protected]>
This commit is contained in:
co-authored by
UltralyticsAssistant
parent
7be11d365a
commit
f9ca60959b
+1
-1
@@ -27,4 +27,4 @@
|
||||
# ├── test_summarize_pr.py
|
||||
# └── ...
|
||||
|
||||
__version__ = "0.2.4"
|
||||
__version__ = "0.2.5"
|
||||
|
||||
+13
-4
@@ -96,11 +96,15 @@ def generate_pr_review(
|
||||
|
||||
# Filter out generated/vendored files
|
||||
filtered_files = {p: s for p, s in diff_files.items() if not any(re.search(x, p) for x in SKIP_PATTERNS)}
|
||||
skipped_count = len(diff_files) - len(filtered_files)
|
||||
skipped_files = [p for p in diff_files if p not in filtered_files]
|
||||
diff_files = filtered_files
|
||||
|
||||
if not diff_files:
|
||||
return {"comments": [], "summary": f"All {skipped_count} changed files are generated/vendored (skipped review)"}
|
||||
return {
|
||||
"comments": [],
|
||||
"summary": f"All {len(skipped_files)} changed files are generated/vendored (skipped review)",
|
||||
"skipped_files": skipped_files,
|
||||
}
|
||||
|
||||
file_list = list(diff_files.keys())
|
||||
diff_truncated = len(augmented_diff) > MAX_PROMPT_CHARS
|
||||
@@ -299,7 +303,7 @@ def generate_pr_review(
|
||||
"comments_before_filtering": comments_before_filtering,
|
||||
"diff_files": diff_files,
|
||||
"diff_truncated": diff_truncated,
|
||||
"skipped_files": skipped_count,
|
||||
"skipped_files": skipped_files,
|
||||
}
|
||||
)
|
||||
print(f"Valid comments after filtering: {len(response['comments'])}")
|
||||
@@ -369,7 +373,12 @@ def post_review_summary(event: Action, review_data: dict, review_number: int) ->
|
||||
body += "\n⚠️ **Large PR**: Review focused on critical issues. Some details may not be covered.\n"
|
||||
|
||||
if skipped := review_data.get("skipped_files"):
|
||||
body += f"\n📋 **Skipped {skipped} file{'s' if skipped != 1 else ''}** (lock files, minified, images, etc.)\n"
|
||||
count = len(skipped)
|
||||
skip_str = f"📋 Skipped {count} file{'s' if count != 1 else ''} (lock files, minified, images, etc.)"
|
||||
file_list = "\n".join(f"- `{f}`" for f in sorted(skipped[:100]))
|
||||
if count > 100:
|
||||
file_list += f"\n{count - 100} more..."
|
||||
body += f"\n<details><summary>{skip_str}</summary>\n\n{file_list}\n</details>\n"
|
||||
|
||||
# Build inline comments for the review
|
||||
review_comments = []
|
||||
|
||||
Reference in New Issue
Block a user