espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-06-05 21:14:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[bbr] update Manager::SendBackboneAnswer() to use InitAsPost() (#12537)

Browse Source 
This commit updates `Manager::SendBackboneAnswer()` to use
`Coap::Message::InitAsPost()`, which automatically determines the
CoAP message type (Confirmable vs. Non-Confirmable) based on whether
the destination address is multicast. This simplifies the code and
removes the need for the local `proactive` boolean variable.
This commit is contained in:
Abtin Keshavarzian
2026-02-24 13:11:40 -08:00
committed by GitHub
parent d8dc2a41d8
commit c83f924a3d
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/backbone_router/bbr_manager.cpp
+3 -5
View File
@@ -631,12 +631,10 @@ Error Manager::SendBackboneAnswer(const Ip6::Address &aDstAddr,
Error error = kErrorNone;
Coap::Message *message = nullptr;
Ip6::MessageInfo messageInfo;
bool proactive = aDstAddr.IsMulticast();
VerifyOrExit((message = mBackboneTmfAgent.NewPriorityMessage()) != nullptr, error = kErrorNoBufs);
SuccessOrExit(error = message->Init(proactive ? Coap::kTypeNonConfirmable : Coap::kTypeConfirmable, Coap::kCodePost,
kUriBackboneAnswer));
SuccessOrExit(error = message->InitAsPost(aDstAddr, kUriBackboneAnswer));
SuccessOrExit(error = message->AppendPayloadMarker());
SuccessOrExit(error = Tlv::Append<ThreadTargetTlv>(*message, aDua));
@@ -662,8 +660,8 @@ Error Manager::SendBackboneAnswer(const Ip6::Address &aDstAddr,
error = mBackboneTmfAgent.SendMessage(*message, messageInfo);
exit:
LogInfo("Send %s for %s (rloc16=%04x): %s", proactive ? "PRO_BB.ntf" : "BB.ans", aDua.ToString().AsCString(),
aSrcRloc16, ErrorToString(error));
LogInfo("Send %s for %s (rloc16=%04x): %s", aDstAddr.IsMulticast() ? "PRO_BB.ntf" : "BB.ans",
aDua.ToString().AsCString(), aSrcRloc16, ErrorToString(error));
FreeMessageOnError(message, error);
return error;