[tmf] skip copy of MessageInfo for empty ack (#8926)

This commit is contained in:
Abtin Keshavarzian
2023-04-05 11:00:23 -07:00
committed by GitHub
parent 6e79add03f
commit e587d43e4b
3 changed files with 10 additions and 13 deletions
+3 -4
View File
@@ -97,9 +97,8 @@ exit:
template <>
void PanIdQueryClient::HandleTmf<kUriPanIdConflict>(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo)
{
uint16_t panId;
Ip6::MessageInfo responseInfo(aMessageInfo);
uint32_t mask;
uint16_t panId;
uint32_t mask;
VerifyOrExit(aMessage.IsConfirmablePostRequest());
@@ -111,7 +110,7 @@ void PanIdQueryClient::HandleTmf<kUriPanIdConflict>(Coap::Message &aMessage, con
mCallback.InvokeIfSet(panId, mask);
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, responseInfo));
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, aMessageInfo));
LogInfo("sent panid query conflict response");
+4 -5
View File
@@ -66,10 +66,9 @@ void AnnounceBeginServer::SendAnnounce(uint32_t aChannelMask, uint8_t aCount, ui
template <>
void AnnounceBeginServer::HandleTmf<kUriAnnounceBegin>(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo)
{
uint32_t mask;
uint8_t count;
uint16_t period;
Ip6::MessageInfo responseInfo(aMessageInfo);
uint32_t mask;
uint8_t count;
uint16_t period;
VerifyOrExit(aMessage.IsPostRequest());
VerifyOrExit((mask = MeshCoP::ChannelMaskTlv::GetChannelMask(aMessage)) != 0);
@@ -81,7 +80,7 @@ void AnnounceBeginServer::HandleTmf<kUriAnnounceBegin>(Coap::Message &aMessage,
if (aMessage.IsConfirmable() && !aMessageInfo.GetSockAddr().IsMulticast())
{
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, responseInfo));
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, aMessageInfo));
LogInfo("Sent announce begin response");
}
+3 -4
View File
@@ -60,9 +60,8 @@ PanIdQueryServer::PanIdQueryServer(Instance &aInstance)
template <>
void PanIdQueryServer::HandleTmf<kUriPanIdQuery>(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo)
{
uint16_t panId;
Ip6::MessageInfo responseInfo(aMessageInfo);
uint32_t mask;
uint16_t panId;
uint32_t mask;
VerifyOrExit(aMessage.IsPostRequest());
VerifyOrExit((mask = MeshCoP::ChannelMaskTlv::GetChannelMask(aMessage)) != 0);
@@ -76,7 +75,7 @@ void PanIdQueryServer::HandleTmf<kUriPanIdQuery>(Coap::Message &aMessage, const
if (aMessage.IsConfirmable() && !aMessageInfo.GetSockAddr().IsMulticast())
{
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, responseInfo));
SuccessOrExit(Get<Tmf::Agent>().SendEmptyAck(aMessage, aMessageInfo));
LogInfo("sent panid query response");
}